Anthropic UsageAccessor #2068
Closed
Anthropic UsageAccessor #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilayaperumalg
commented
Jan 14, 2025
ilayaperumalg
commented
- This PR introduces Usage accessor to retrieve the usage metadata fields from the ChatCompletion Usage response metadata - Having UsageAccessor would help enable the clients getting access to the entire metadata instead of pre-defined set of metadata
- Add utility method to UsageUtils to parseLong value from the metadata value object
- Add tests
- This PR introduces Usage accessor to retrieve the usage metadata fields from the ChatCompletion Usage response metadata
- Having UsageAccessor would help enable the clients getting access to the entire metadata instead of pre-defined set of metadata
- Add utility method to UsageUtils to parseLong value from the metadata value object
- Add tests
ilayaperumalg
force-pushed
the
anthropic-usage-accessor
branch
from
e06d9db to
ac32938
Compare
ilayaperumalg
commented
Jan 15, 2025
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
Member
Author
There was a problem hiding this comment.
should be removed as this is implicit.
ilayaperumalg
commented
Jan 15, 2025
| return UsageUtils.parseLong(this.usage.get(CACHE_READ_INPUT_TOKENS)); | ||
| } | ||
|
|
||
| public Map<String, Object> getUsage() { |
Member
Author
There was a problem hiding this comment.
Rename this to getUsageData()
ilayaperumalg
commented
Jan 15, 2025
| * | ||
| * @author Ilayaperumal Gopinathan | ||
| */ | ||
| public record AnthropicUsageAccessor(Map<String, Object> usage) implements Usage { |
Member
Author
There was a problem hiding this comment.
Can be simplified to AnthropicUsage
ilayaperumalg
commented
Jan 15, 2025
| * | ||
| * @author Ilayaperumal Gopinathan | ||
| */ | ||
| public record AnthropicUsageAccessor(Map<String, Object> usage) implements Usage { |
Member
Author
There was a problem hiding this comment.
For the extensibility let's not make this record
ilayaperumalg
commented
Jan 15, 2025
| */ | ||
| public static Long parseLong(Object value) { | ||
| if (value == null) { | ||
| return null; |
Member
Author
There was a problem hiding this comment.
If null, return -1
Member
|
Closing this PR as the design to return the 'native' usage classes with a method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.